Added Serbian Cyrillic translation and corrected Serbian Latin translаtion #2553
+2,626
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corrected linter errors. |
|
I am not sure what exactly is failing in 18.x. Anyone help with this? |
|
@imilos : The failure in Node 18.x looks to be a random failure, not caused by this PR. We occasionally have a few tests that fail semi-randomly (which is unfortunate), but we know that they will usually succeed if we rerun the test. I just triggered a re-run of the 18.x tests on this PR. So, this looks good. I'll pull this over to our 7.6.x maintenance board to find a tester so that we can try to include this in 7.6.1. Thanks! |
tdonohue
added
i18n / l10n
alanorth
changed the title
|
Thanks @imilos. I tested this on DSpace 7.6 and it looks good. It's also good you caught the minor errors in the Serbian Latin strings. Хвала! |
alanorth
approved these changes
Oct 24, 2023
|
Successfully created backport PR for |
alanorth
removed
the
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Serbian Cyrillic translation and corrected Serbian Latin translаtion
Instructions for Reviewers
Added
sr-cyr.json5translation and modified config files to include this translation. Also slightly corrected Serbian Latin.List of changes in this PR:
config.example.ymlanddefault-app-config.ts.